-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[maint] Fix CI (GitHub actions workflow and tox.ini) #55
Conversation
thanks so much @psobolewskiPhD !! the MPS error looks strange to me -- it says it's out of memory? otherwise the windows errors are expected due to changes in the dynamics code resulting in different numbers of cells from cellpose v2 and beyond |
Yea sorry I just left it last night, I was tracking down the failures and got sleepy. |
Thanks! Ah no we did also have failing regression tests, and I've updated the expected output with each release, so we can do that here too by re-setting the assert values - or I can change it to the same regression tests as cellpose (although I don't have a diameter test there) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55 +/- ##
==========================================
+ Coverage 54.31% 60.08% +5.77%
==========================================
Files 3 3
Lines 232 233 +1
==========================================
+ Hits 126 140 +14
+ Misses 106 93 -13 ☔ View full report in Codecov by Sentry. |
Ok, things are working. The diameter value I get when running locally with MPS is different than with CPU, so I split the difference so that I can run tests locally. And I explicitly set cyto3 and the number of cells I get with that. I'll try re-enabling Ubuntu tests next. |
@carsen-stringer I think it's ready for review now 😃 |
thank you so much! 🔥 🚀 |
The github action and tox.ini got out of sync with some strange multi-python tox envs:
https://github.com/MouseLand/cellpose-napari/actions/runs/10851583106/job/30115669221?pr=33#step:7:157
In this PR I try to clean up old/unused elements from the github actions workflow and update tox.ini to python 3.9-3.12.
I also add using concurrency so that multiple pushes will cancel tests, rather than piling them up.
I restored macOS, ubuntu, and Windows tests, updating the test suite to specify model cyto3 such that the expected values can be specified.
I also monkeypatch such that on CI CPU is used. This gives a different diameter value, so I split the difference in the
isclose
so that tests work on CI and locally.Finally I do some cleanup of imports and comments.